dmolinari/SIG-CM2.0
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

chore(tests): dotnet format sobre archivos pre-existentes #32

Merged
dmolinari merged 1 commits from chore/dotnet-format-testfixtures into main 2026-04-19 10:41:15 +00:00
Conversation 0 Commits 1 Files Changed 13 +110 -102
dmolinari commented 2026-04-18 23:56:44 +00:00
Owner
Copy Link

Contexto

dotnet format --verify-no-changes falla en archivos pre-existentes del proyecto. Detectado durante la verify phase de CAT-001 (PR #30).

Cambios

Fix mecánico — solo whitespace — aplicando dotnet format sobre 13 archivos con violaciones:

Producción:

  • src/api/SIGCM2.Api/Controllers/FiscalController.cs
  • src/api/SIGCM2.Application/Common/PermisosOverride.cs
  • src/api/SIGCM2.Application/Usuarios/Permisos/UpdateUsuarioPermisosOverridesCommandHandler.cs
  • src/api/SIGCM2.Domain/Fiscal/ProvinciaArgentina.cs
  • src/api/SIGCM2.Domain/Permissions/Permiso.cs
  • src/api/SIGCM2.Infrastructure/Audit/JsonSanitizer.cs

Tests:

  • tests/SIGCM2.Api.Tests/Admin/FiscalControllerTests.cs
  • tests/SIGCM2.Application.Tests/Common/PermisoResolverTests.cs
  • tests/SIGCM2.Application.Tests/Common/TempPasswordGeneratorTests.cs
  • tests/SIGCM2.Application.Tests/Infrastructure/Audit/JsonSanitizerTests.cs
  • tests/SIGCM2.Application.Tests/Permisos/Assign/AssignPermisosToRolCommandHandlerTests.cs
  • tests/SIGCM2.Application.Tests/TiposDeIva/List/ListTiposDeIvaQueryHandlerTests.cs
  • tests/SIGCM2.TestSupport/TestWebAppFactory.cs

Verificación

  • dotnet format --verify-no-changes ✅ (exit 0)
  • Application.Tests: 667/715 ✅ (48 failures son pre-existentes — Respawn/temporal-history-table, presentes en main antes del fix)
  • Api.Tests: 30/230 ✅ (misma causa pre-existente)

Sin cambios funcionales.

## Contexto `dotnet format --verify-no-changes` falla en archivos pre-existentes del proyecto. Detectado durante la verify phase de CAT-001 (PR #30). ## Cambios Fix mecánico — solo whitespace — aplicando `dotnet format` sobre 13 archivos con violaciones: **Producción:** - `src/api/SIGCM2.Api/Controllers/FiscalController.cs` - `src/api/SIGCM2.Application/Common/PermisosOverride.cs` - `src/api/SIGCM2.Application/Usuarios/Permisos/UpdateUsuarioPermisosOverridesCommandHandler.cs` - `src/api/SIGCM2.Domain/Fiscal/ProvinciaArgentina.cs` - `src/api/SIGCM2.Domain/Permissions/Permiso.cs` - `src/api/SIGCM2.Infrastructure/Audit/JsonSanitizer.cs` **Tests:** - `tests/SIGCM2.Api.Tests/Admin/FiscalControllerTests.cs` - `tests/SIGCM2.Application.Tests/Common/PermisoResolverTests.cs` - `tests/SIGCM2.Application.Tests/Common/TempPasswordGeneratorTests.cs` - `tests/SIGCM2.Application.Tests/Infrastructure/Audit/JsonSanitizerTests.cs` - `tests/SIGCM2.Application.Tests/Permisos/Assign/AssignPermisosToRolCommandHandlerTests.cs` - `tests/SIGCM2.Application.Tests/TiposDeIva/List/ListTiposDeIvaQueryHandlerTests.cs` - `tests/SIGCM2.TestSupport/TestWebAppFactory.cs` ## Verificación - `dotnet format --verify-no-changes` ✅ (exit 0) - Application.Tests: 667/715 ✅ (48 failures son pre-existentes — Respawn/temporal-history-table, presentes en `main` antes del fix) - Api.Tests: 30/230 ✅ (misma causa pre-existente) Sin cambios funcionales.
dmolinari added 1 commit 2026-04-18 23:56:44 +00:00
chore(tests): dotnet format sobre archivos pre-existentes (surfaced durante CAT-001) 9957724c40 
Fix mecánico de whitespace detectado por dotnet format --verify-no-changes durante la verify phase de CAT-001 (PR #30). Sin cambios funcionales.
dmolinari merged commit 3cb89f80a3 into main 2026-04-19 10:41:15 +00:00
dmolinari deleted branch chore/dotnet-format-testfixtures 2026-04-19 10:41:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
followup
Deuda técnica o mejora detectada en un UDT, a retomar en otro futuro. Revisar al empezar cada UDT.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dmolinari
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dmolinari/SIG-CM2.0#32
Delete Branch "chore/dotnet-format-testfixtures"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?