dmolinari
26efb74c22
7 command handlers del módulo Usuarios ahora auditan via IAuditLogger:
| Handler | Action |
|-----------------------------------------|-------------------------|
| CreateUsuarioCommandHandler | usuario.create |
| UpdateUsuarioCommandHandler | usuario.update |
| DeactivateUsuarioCommandHandler | usuario.deactivate |
| ReactivateUsuarioCommandHandler | usuario.reactivate |
| ChangeMyPasswordCommandHandler | usuario.password_change |
| ResetUsuarioPasswordCommandHandler | usuario.password_reset |
| UpdateUsuarioPermisosOverridesHandler | usuario.permisos_update |
Patrón por handler (per design #D-1):
using (var tx = new TransactionScope(Required, ReadCommitted, AsyncFlowEnabled))
{
await repo.UpdateAsync(...);
await audit.LogAsync(...);
tx.Complete();
}
// post-commit reads OUTSIDE the using block
var updated = await repo.GetDetailAsync(...);
Metadata captured:
- usuario.create: after={username, nombre, apellido, email, rol} — NO password.
- usuario.update: {before, after} diff of editable fields.
- usuario.password_reset: {targetId} only — tempPassword is NEVER persisted to
audit (returned to caller once, never stored).
- usuario.permisos_update: {before, after} of grant/deny override lists.
Key fix during implementation: initially used 'using var tx = ...' (bare
declaration). This kept the TransactionScope active for the rest of the method,
causing 'The current TransactionScope is already complete' when post-commit
reads (GetDetailAsync) tried to enlist. Solution: explicit 'using (var tx = ...)
{ ... }' block that disposes the scope before post-commit reads.
AuditContextMissingException surfaces from AuditLogger when IAuditContext
lacks ActorUserId — fail-closed per #REQ-AUD-4. In integration tests, the
middleware populates ActorUserId from the JWT sub of the authenticated admin.
Test updates: 6 existing unit test classes now inject IAuditLogger mock:
- CreateUsuarioCommandHandlerTests
- UpdateUsuarioCommandHandlerTests
- DeactivateUsuarioCommandHandlerTests
- ReactivateUsuarioCommandHandlerTests
- ChangeMyPasswordCommandHandlerTests
- ResetUsuarioPasswordCommandHandlerTests
Follow-up #6 ([Auditoría] Registrar admin creador en alta de usuarios) is
closed: CreateUsuarioCommandHandler now records ActorUserId = admin JWT sub
on every user creation. TODO comment removed.
Suite: 378/378 Application.Tests + 141/141 Api.Tests = 519/519 passing.
Closes #6
Refs: sdd/udt-010-auditoria-trazabilidad/{spec#REQ-UM-AUD, design, tasks#B7}
73 lines
2.8 KiB
C#
73 lines
2.8 KiB
C#
using System.Transactions;
|
|
using SIGCM2.Application.Abstractions;
|
|
using SIGCM2.Application.Abstractions.Persistence;
|
|
using SIGCM2.Application.Audit;
|
|
using SIGCM2.Application.Common;
|
|
using SIGCM2.Application.Usuarios.GetById;
|
|
using SIGCM2.Domain.Exceptions;
|
|
|
|
namespace SIGCM2.Application.Usuarios.Deactivate;
|
|
|
|
public sealed class DeactivateUsuarioCommandHandler : ICommandHandler<DeactivateUsuarioCommand, UsuarioDetailDto>
|
|
{
|
|
private readonly IUsuarioRepository _repository;
|
|
private readonly IRefreshTokenRepository _refreshTokenRepository;
|
|
private readonly IAuditLogger _audit;
|
|
|
|
public DeactivateUsuarioCommandHandler(
|
|
IUsuarioRepository repository,
|
|
IRefreshTokenRepository refreshTokenRepository,
|
|
IAuditLogger audit)
|
|
{
|
|
_repository = repository;
|
|
_refreshTokenRepository = refreshTokenRepository;
|
|
_audit = audit;
|
|
}
|
|
|
|
public async Task<UsuarioDetailDto> Handle(DeactivateUsuarioCommand cmd)
|
|
{
|
|
var target = await _repository.GetByIdAsync(cmd.UsuarioId)
|
|
?? throw new UsuarioNotFoundException(cmd.UsuarioId);
|
|
|
|
// Idempotent: already inactive → return as-is without touching FechaModificacion
|
|
if (!target.Activo)
|
|
{
|
|
return new UsuarioDetailDto(
|
|
target.Id, target.Username, target.Nombre, target.Apellido,
|
|
target.Email, target.Rol, target.Activo, target.MustChangePassword,
|
|
target.UltimoLogin, target.FechaModificacion);
|
|
}
|
|
|
|
// Guard: anti-lockout
|
|
if (target.Rol == "admin" && await _repository.CountActiveAdminsAsync() <= 1)
|
|
throw new LastAdminLockoutException();
|
|
|
|
var fields = new UpdateUsuarioFields(target.Nombre, target.Apellido, target.Email, target.Rol, false);
|
|
var now = DateTime.UtcNow;
|
|
|
|
using (var tx = new TransactionScope(
|
|
TransactionScopeOption.Required,
|
|
new TransactionOptions { IsolationLevel = IsolationLevel.ReadCommitted },
|
|
TransactionScopeAsyncFlowOption.Enabled))
|
|
{
|
|
await _repository.UpdateAsync(cmd.UsuarioId, fields, now);
|
|
await _refreshTokenRepository.RevokeAllActiveForUserAsync(cmd.UsuarioId, now);
|
|
|
|
await _audit.LogAsync(
|
|
action: "usuario.deactivate",
|
|
targetType: "Usuario",
|
|
targetId: cmd.UsuarioId.ToString());
|
|
|
|
tx.Complete();
|
|
}
|
|
|
|
var updated = await _repository.GetDetailAsync(cmd.UsuarioId)
|
|
?? throw new UsuarioNotFoundException(cmd.UsuarioId);
|
|
|
|
return new UsuarioDetailDto(
|
|
updated.Id, updated.Username, updated.Nombre, updated.Apellido,
|
|
updated.Email, updated.Rol, updated.Activo, updated.MustChangePassword,
|
|
updated.UltimoLogin, updated.FechaModificacion);
|
|
}
|
|
}
|