From e5b6c06f644ea119bfec941406a5b7756be91384 Mon Sep 17 00:00:00 2001 From: dmolinari Date: Sat, 18 Apr 2026 21:44:40 -0300 Subject: [PATCH] refactor(tests): Api.Tests apunta a SIGCM2_Test_Api via TestConnectionStrings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Todos los archivos de Api.Tests reemplazan la connection string hardcodeada por TestConnectionStrings.ApiTestDb. Cada proyecto de tests ahora tiene su propia base de datos aislada, eliminando la contención entre Application.Tests y Api.Tests que causaba flakiness. --- tests/SIGCM2.Api.Tests/Admin/FiscalControllerTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Admin/MediosControllerTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Admin/PuntosDeVentaControllerTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Admin/SeccionesControllerTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Admin/V014MigrationTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Admin/V015MigrationTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Audit/AuditControllerTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Audit/TransactionScopeSpikeTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Audit/V010MigrationTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Permisos/PermisosEndpointTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Roles/RolesEndpointTests.cs | 3 +-- .../SIGCM2.Api.Tests/Usuarios/ChangeMyPasswordEndpointTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Usuarios/CreateUsuarioEndpointTests.cs | 3 +-- .../Usuarios/DeactivateReactivateEndpointTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Usuarios/GetUsuarioByIdEndpointTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Usuarios/ListUsuariosEndpointTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Usuarios/ResetPasswordEndpointTests.cs | 3 +-- tests/SIGCM2.Api.Tests/Usuarios/UpdateUsuarioEndpointTests.cs | 3 +-- .../SIGCM2.Api.Tests/Usuarios/UsuarioPermisosEndpointTests.cs | 3 +-- 19 files changed, 19 insertions(+), 38 deletions(-) diff --git a/tests/SIGCM2.Api.Tests/Admin/FiscalControllerTests.cs b/tests/SIGCM2.Api.Tests/Admin/FiscalControllerTests.cs index 9c7ed2b..b8ae790 100644 --- a/tests/SIGCM2.Api.Tests/Admin/FiscalControllerTests.cs +++ b/tests/SIGCM2.Api.Tests/Admin/FiscalControllerTests.cs @@ -17,8 +17,7 @@ namespace SIGCM2.Api.Tests.Admin; [Collection("ApiIntegration")] public sealed class FiscalControllerTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string IvaEndpoint = "/api/v1/admin/fiscal/iva"; private const string IibbEndpoint = "/api/v1/admin/fiscal/iibb"; diff --git a/tests/SIGCM2.Api.Tests/Admin/MediosControllerTests.cs b/tests/SIGCM2.Api.Tests/Admin/MediosControllerTests.cs index bb079a1..467c668 100644 --- a/tests/SIGCM2.Api.Tests/Admin/MediosControllerTests.cs +++ b/tests/SIGCM2.Api.Tests/Admin/MediosControllerTests.cs @@ -15,8 +15,7 @@ namespace SIGCM2.Api.Tests.Admin; [Collection("ApiIntegration")] public sealed class MediosControllerTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string Endpoint = "/api/v1/admin/medios"; private const string AdminUsername = "admin"; diff --git a/tests/SIGCM2.Api.Tests/Admin/PuntosDeVentaControllerTests.cs b/tests/SIGCM2.Api.Tests/Admin/PuntosDeVentaControllerTests.cs index 5bffba0..2f89ba7 100644 --- a/tests/SIGCM2.Api.Tests/Admin/PuntosDeVentaControllerTests.cs +++ b/tests/SIGCM2.Api.Tests/Admin/PuntosDeVentaControllerTests.cs @@ -16,8 +16,7 @@ namespace SIGCM2.Api.Tests.Admin; [Collection("ApiIntegration")] public sealed class PuntosDeVentaControllerTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string Endpoint = "/api/v1/admin/puntos-de-venta"; private const string MediosEndpoint = "/api/v1/admin/medios"; diff --git a/tests/SIGCM2.Api.Tests/Admin/SeccionesControllerTests.cs b/tests/SIGCM2.Api.Tests/Admin/SeccionesControllerTests.cs index 8aeee47..00ac00a 100644 --- a/tests/SIGCM2.Api.Tests/Admin/SeccionesControllerTests.cs +++ b/tests/SIGCM2.Api.Tests/Admin/SeccionesControllerTests.cs @@ -15,8 +15,7 @@ namespace SIGCM2.Api.Tests.Admin; [Collection("ApiIntegration")] public sealed class SeccionesControllerTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string Endpoint = "/api/v1/admin/secciones"; private const string MediosEndpoint = "/api/v1/admin/medios"; diff --git a/tests/SIGCM2.Api.Tests/Admin/V014MigrationTests.cs b/tests/SIGCM2.Api.Tests/Admin/V014MigrationTests.cs index 963983e..b1c98e4 100644 --- a/tests/SIGCM2.Api.Tests/Admin/V014MigrationTests.cs +++ b/tests/SIGCM2.Api.Tests/Admin/V014MigrationTests.cs @@ -21,8 +21,7 @@ namespace SIGCM2.Api.Tests.Admin; [Collection("ApiIntegration")] public sealed class V014MigrationTests : IClassFixture { - private const string ConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string ConnectionString = TestConnectionStrings.ApiTestDb; public V014MigrationTests(SIGCM2.TestSupport.TestWebAppFactory _) { diff --git a/tests/SIGCM2.Api.Tests/Admin/V015MigrationTests.cs b/tests/SIGCM2.Api.Tests/Admin/V015MigrationTests.cs index ad9990d..0d22daf 100644 --- a/tests/SIGCM2.Api.Tests/Admin/V015MigrationTests.cs +++ b/tests/SIGCM2.Api.Tests/Admin/V015MigrationTests.cs @@ -21,8 +21,7 @@ namespace SIGCM2.Api.Tests.Admin; [Collection("ApiIntegration")] public sealed class V015MigrationTests : IClassFixture { - private const string ConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string ConnectionString = TestConnectionStrings.ApiTestDb; public V015MigrationTests(SIGCM2.TestSupport.TestWebAppFactory _) { diff --git a/tests/SIGCM2.Api.Tests/Audit/AuditControllerTests.cs b/tests/SIGCM2.Api.Tests/Audit/AuditControllerTests.cs index ee7ddd3..4d3d4d5 100644 --- a/tests/SIGCM2.Api.Tests/Audit/AuditControllerTests.cs +++ b/tests/SIGCM2.Api.Tests/Audit/AuditControllerTests.cs @@ -18,8 +18,7 @@ namespace SIGCM2.Api.Tests.Audit; [Collection("ApiIntegration")] public sealed class AuditControllerTests : IClassFixture { - private const string ConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string ConnectionString = TestConnectionStrings.ApiTestDb; private readonly TestWebAppFactory _factory; diff --git a/tests/SIGCM2.Api.Tests/Audit/TransactionScopeSpikeTests.cs b/tests/SIGCM2.Api.Tests/Audit/TransactionScopeSpikeTests.cs index 8c7bcf6..622ec9b 100644 --- a/tests/SIGCM2.Api.Tests/Audit/TransactionScopeSpikeTests.cs +++ b/tests/SIGCM2.Api.Tests/Audit/TransactionScopeSpikeTests.cs @@ -12,8 +12,7 @@ namespace SIGCM2.Api.Tests.Audit; [Collection("ApiIntegration")] public sealed class TransactionScopeSpikeTests { - private const string ConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string ConnectionString = TestConnectionStrings.ApiTestDb; [Fact] public async Task TransactionScope_DoesNotEscalateToMSDTC_WithSingleConnectionString() diff --git a/tests/SIGCM2.Api.Tests/Audit/V010MigrationTests.cs b/tests/SIGCM2.Api.Tests/Audit/V010MigrationTests.cs index e433d95..15ff12b 100644 --- a/tests/SIGCM2.Api.Tests/Audit/V010MigrationTests.cs +++ b/tests/SIGCM2.Api.Tests/Audit/V010MigrationTests.cs @@ -13,8 +13,7 @@ namespace SIGCM2.Api.Tests.Audit; [Collection("ApiIntegration")] public sealed class V010MigrationTests : IClassFixture { - private const string ConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string ConnectionString = TestConnectionStrings.ApiTestDb; public V010MigrationTests(SIGCM2.TestSupport.TestWebAppFactory _) { diff --git a/tests/SIGCM2.Api.Tests/Permisos/PermisosEndpointTests.cs b/tests/SIGCM2.Api.Tests/Permisos/PermisosEndpointTests.cs index 2936a27..d641a0a 100644 --- a/tests/SIGCM2.Api.Tests/Permisos/PermisosEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Permisos/PermisosEndpointTests.cs @@ -15,8 +15,7 @@ namespace SIGCM2.Api.Tests.Permisos; [Collection("ApiIntegration")] public sealed class PermisosEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string AdminUsername = "admin"; private const string AdminPassword = "@Diego550@"; diff --git a/tests/SIGCM2.Api.Tests/Roles/RolesEndpointTests.cs b/tests/SIGCM2.Api.Tests/Roles/RolesEndpointTests.cs index 856b011..c2f27cb 100644 --- a/tests/SIGCM2.Api.Tests/Roles/RolesEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Roles/RolesEndpointTests.cs @@ -14,8 +14,7 @@ namespace SIGCM2.Api.Tests.Roles; [Collection("ApiIntegration")] public sealed class RolesEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string Endpoint = "/api/v1/roles"; private const string AdminUsername = "admin"; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/ChangeMyPasswordEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/ChangeMyPasswordEndpointTests.cs index 5c3641b..8f5accd 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/ChangeMyPasswordEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/ChangeMyPasswordEndpointTests.cs @@ -14,8 +14,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class ChangeMyPasswordEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; // This hash corresponds to "@Diego550@" private const string DefaultHash = "$2a$12$rmq6tlSAQ8WXhR2CwLCSeuwCJKz/.8Eab95UQCUNfwe4dokeOqMcW"; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/CreateUsuarioEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/CreateUsuarioEndpointTests.cs index abaa702..b9b742f 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/CreateUsuarioEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/CreateUsuarioEndpointTests.cs @@ -17,8 +17,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class CreateUsuarioEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string Endpoint = "/api/v1/users"; private const string AdminUsername = "admin"; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/DeactivateReactivateEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/DeactivateReactivateEndpointTests.cs index 47a6e6d..8b23c6e 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/DeactivateReactivateEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/DeactivateReactivateEndpointTests.cs @@ -14,8 +14,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class DeactivateReactivateEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private readonly HttpClient _client; private readonly SqlTestFixture _db; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/GetUsuarioByIdEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/GetUsuarioByIdEndpointTests.cs index 57088c6..c7f3f55 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/GetUsuarioByIdEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/GetUsuarioByIdEndpointTests.cs @@ -14,8 +14,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class GetUsuarioByIdEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private readonly HttpClient _client; private readonly SqlTestFixture _db; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/ListUsuariosEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/ListUsuariosEndpointTests.cs index 8180731..39a0bb2 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/ListUsuariosEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/ListUsuariosEndpointTests.cs @@ -14,8 +14,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class ListUsuariosEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private readonly HttpClient _client; private readonly SqlTestFixture _db; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/ResetPasswordEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/ResetPasswordEndpointTests.cs index 6ce411e..98e58db 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/ResetPasswordEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/ResetPasswordEndpointTests.cs @@ -14,8 +14,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class ResetPasswordEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private readonly HttpClient _client; private readonly SqlTestFixture _db; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/UpdateUsuarioEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/UpdateUsuarioEndpointTests.cs index 7e6f64c..76397d0 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/UpdateUsuarioEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/UpdateUsuarioEndpointTests.cs @@ -14,8 +14,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class UpdateUsuarioEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private readonly HttpClient _client; private readonly SqlTestFixture _db; diff --git a/tests/SIGCM2.Api.Tests/Usuarios/UsuarioPermisosEndpointTests.cs b/tests/SIGCM2.Api.Tests/Usuarios/UsuarioPermisosEndpointTests.cs index 7571acb..436e1b8 100644 --- a/tests/SIGCM2.Api.Tests/Usuarios/UsuarioPermisosEndpointTests.cs +++ b/tests/SIGCM2.Api.Tests/Usuarios/UsuarioPermisosEndpointTests.cs @@ -15,8 +15,7 @@ namespace SIGCM2.Api.Tests.Usuarios; [Collection("ApiIntegration")] public sealed class UsuarioPermisosEndpointTests : IAsyncLifetime { - private const string TestConnectionString = - "Server=TECNICA3;Database=SIGCM2_Test;User Id=desarrollo;Password=desarrollo2026;TrustServerCertificate=True;"; + private const string TestConnectionString = TestConnectionStrings.ApiTestDb; private const string AdminUsername = "admin"; private const string AdminPassword = "@Diego550@";