feat(application): Rubros commands/queries + RubroTreeBuilder + audit (CAT-001)

2026-04-18 19:25:35 -03:00
parent dcb2e5ada6
commit d9fc9a2867
26 changed files with 1330 additions and 0 deletions
--- a/tests/SIGCM2.Application.Tests/Rubros/Deactivate/DeactivateRubroCommandHandlerTests.cs
+++ b/tests/SIGCM2.Application.Tests/Rubros/Deactivate/DeactivateRubroCommandHandlerTests.cs
@@ -0,0 +1,106 @@
+using FluentAssertions;
+using Microsoft.Extensions.Time.Testing;
+using NSubstitute;
+using SIGCM2.Application.Abstractions.Persistence;
+using SIGCM2.Application.Audit;
+using SIGCM2.Application.Rubros.Deactivate;
+using SIGCM2.Domain.Entities;
+using SIGCM2.Domain.Exceptions;
+
+namespace SIGCM2.Application.Tests.Rubros.Deactivate;
+
+public class DeactivateRubroCommandHandlerTests
+{
+    private readonly IRubroRepository _repo = Substitute.For<IRubroRepository>();
+    private readonly IAuditLogger _audit = Substitute.For<IAuditLogger>();
+    private readonly FakeTimeProvider _timeProvider = new(new DateTimeOffset(2026, 4, 18, 12, 0, 0, TimeSpan.Zero));
+    private readonly DeactivateRubroCommandHandler _handler;
+
+    private static Rubro LeafRubro(int id = 10) => new(id, null, "Autos", 0, activo: true,
+        tarifarioBaseId: null, fechaCreacion: DateTime.UtcNow, fechaModificacion: null);
+
+    public DeactivateRubroCommandHandlerTests()
+    {
+        _repo.CountActiveChildrenAsync(Arg.Any<int>(), Arg.Any<CancellationToken>()).Returns(0);
+        _handler = new DeactivateRubroCommandHandler(_repo, _audit, _timeProvider);
+    }
+
+    // ── Happy path: leaf soft-delete ─────────────────────────────────────────
+
+    [Fact]
+    public async Task Handle_LeafRubro_SoftDeletes()
+    {
+        _repo.GetByIdAsync(10, Arg.Any<CancellationToken>()).Returns(LeafRubro());
+
+        var result = await _handler.Handle(new DeactivateRubroCommand(Id: 10));
+
+        result.Id.Should().Be(10);
+        result.Activo.Should().BeFalse();
+    }
+
+    [Fact]
+    public async Task Handle_LeafRubro_CallsUpdateAsync()
+    {
+        _repo.GetByIdAsync(10, Arg.Any<CancellationToken>()).Returns(LeafRubro());
+
+        await _handler.Handle(new DeactivateRubroCommand(Id: 10));
+
+        await _repo.Received(1).UpdateAsync(
+            Arg.Is<Rubro>(r => r.Id == 10 && !r.Activo),
+            Arg.Any<CancellationToken>());
+    }
+
+    [Fact]
+    public async Task Handle_LeafRubro_CallsAuditLog()
+    {
+        _repo.GetByIdAsync(10, Arg.Any<CancellationToken>()).Returns(LeafRubro());
+
+        await _handler.Handle(new DeactivateRubroCommand(Id: 10));
+
+        await _audit.Received(1).LogAsync(
+            action: "rubro.deleted",
+            targetType: "Rubro",
+            targetId: "10",
+            metadata: Arg.Any<object?>(),
+            ct: Arg.Any<CancellationToken>());
+    }
+
+    // ── Has active children → RubroTieneHijosActivosException ───────────────
+
+    [Fact]
+    public async Task Handle_HasActiveChildren_ThrowsRubroTieneHijosActivosException()
+    {
+        _repo.GetByIdAsync(5, Arg.Any<CancellationToken>()).Returns(LeafRubro(5));
+        _repo.CountActiveChildrenAsync(5, Arg.Any<CancellationToken>()).Returns(3);
+
+        var act = () => _handler.Handle(new DeactivateRubroCommand(Id: 5));
+
+        await act.Should().ThrowAsync<RubroTieneHijosActivosException>()
+            .Where(ex => ex.Id == 5 && ex.Count == 3);
+    }
+
+    [Fact]
+    public async Task Handle_HasActiveChildren_DoesNotCallAuditLog()
+    {
+        _repo.GetByIdAsync(5, Arg.Any<CancellationToken>()).Returns(LeafRubro(5));
+        _repo.CountActiveChildrenAsync(5, Arg.Any<CancellationToken>()).Returns(1);
+
+        try { await _handler.Handle(new DeactivateRubroCommand(Id: 5)); } catch { }
+
+        await _audit.DidNotReceive().LogAsync(
+            Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>(),
+            Arg.Any<object?>(), Arg.Any<CancellationToken>());
+    }
+
+    // ── Not found → RubroNotFoundException ──────────────────────────────────
+
+    [Fact]
+    public async Task Handle_NotFound_ThrowsRubroNotFoundException()
+    {
+        _repo.GetByIdAsync(99, Arg.Any<CancellationToken>()).Returns((Rubro?)null);
+
+        var act = () => _handler.Handle(new DeactivateRubroCommand(Id: 99));
+
+        await act.Should().ThrowAsync<RubroNotFoundException>();
+    }
+}