dmolinari/SIG-CM2.0
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(backend+tests): reactivate endpoint 500 + test schema mismatches (PRC-001)

Browse Source 
Three bugs surfaced while user smoke-testing Reactivate:

1. ReactivateAsync opened a SECOND connection for GetByIdAsync after the SP
   call, inside the ambient TransactionScope. This promoted the tx to DTC
   (distributed) which requires MSDTC — typically not enabled on dev/prod
   servers. The API returned an opaque 500. Fix: run the post-SP SELECT on
   the SAME connection (local tx stays lightweight / LTM).

2. Agent 1's V023 test refactor wrote 'INSERT INTO dbo.ProductType (Nombre,
   Codigo, Activo)' in 2 test files — but dbo.ProductType has no 'Codigo' or
   'Activo' columns (schema is Nombre + IsActive + flags + multimedia limits).
   Fix: use '(Nombre, HasDuration, RequiresText, RequiresCategory, IsBundle,
   AllowImages)' matching the other test files (ProductQueryRepositoryTests,
   ProductRepositoryTests, ProductPriceRepositoryIntegrationTests).

3. SqlTestFixture.EnsureV021SchemaAsync unconditionally ALTERed the V021-era
   SPs with '@MedioId' body. On second fixture run after V023 had already
   refactored the table, ALTER PROCEDURE body referenced a MedioId column
   that no longer existed — 'Invalid column name MedioId'. Fix: guard the
   V021 SP ALTERs + seedV022 behind 'MedioId column exists' check. If V023
   already dropped MedioId, skip V021 re-install; EnsureV023SchemaAsync
   still recreates SPs with @ProductTypeId.

4. PricingExceptionTests still used 'medioId:' named-arg + '.MedioId' — Agent 2
   renamed the exception property but not these 6 test references.

Tests: 1297/1297 Application.Tests green.
This commit is contained in:
dmolinari
2026-04-21 11:32:23 -03:00
parent 40b5f3904a
commit d7c6cbd4ff
5 changed files with 58 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/SIGCM2.Application.Tests/Domain/Pricing/Exceptions/PricingExceptionTests.cs
View File

@@ -101,23 +101,23 @@ public sealed class PricingExceptionTests
var activeVf = new DateOnly(2026, 4, 1);
var ex = new ChargeableCharConfigForwardOnlyException(
medioId: 5, symbol: "$", newValidFrom: newVf, activeValidFrom: activeVf);
productTypeId: 5, symbol: "$", newValidFrom: newVf, activeValidFrom: activeVf);
ex.MedioId.Should().Be(5);
ex.ProductTypeId.Should().Be(5);
ex.Symbol.Should().Be("$");
ex.NewValidFrom.Should().Be(newVf);
ex.ActiveValidFrom.Should().Be(activeVf);
}
[Fact]
public void ChargeableCharConfigForwardOnlyException_NullMedioId_IsAllowed()
public void ChargeableCharConfigForwardOnlyException_NullProductTypeId_IsAllowed()
{
var ex = new ChargeableCharConfigForwardOnlyException(
medioId: null, symbol: "$",
productTypeId: null, symbol: "$",
newValidFrom: new DateOnly(2026, 3, 1),
activeValidFrom: new DateOnly(2026, 4, 1));
ex.MedioId.Should().BeNull();
ex.ProductTypeId.Should().BeNull();
}
[Fact]
@@ -127,7 +127,7 @@ public sealed class PricingExceptionTests
var activeVf = new DateOnly(2026, 4, 1);
var ex = new ChargeableCharConfigForwardOnlyException(
medioId: null, symbol: "$", newValidFrom: newVf, activeValidFrom: activeVf);
productTypeId: null, symbol: "$", newValidFrom: newVf, activeValidFrom: activeVf);
ex.Message.Should().Contain("2026-03-01");
ex.Message.Should().Contain("2026-04-01");
@@ -137,7 +137,7 @@ public sealed class PricingExceptionTests
public void ChargeableCharConfigForwardOnlyException_InheritsFromDomainException()
{
var ex = new ChargeableCharConfigForwardOnlyException(
medioId: null, symbol: "$",
productTypeId: null, symbol: "$",
newValidFrom: new DateOnly(2026, 3, 1),
activeValidFrom: new DateOnly(2026, 4, 1));