feat(application): Rubros commands/queries + RubroTreeBuilder + audit (CAT-001)

2026-04-18 19:25:35 -03:00
parent 4c9b7eabaf
commit d4c05cc364
26 changed files with 1330 additions and 0 deletions
--- a/tests/SIGCM2.Application.Tests/Rubros/Update/UpdateRubroCommandHandlerTests.cs
+++ b/tests/SIGCM2.Application.Tests/Rubros/Update/UpdateRubroCommandHandlerTests.cs
@@ -0,0 +1,110 @@
+using FluentAssertions;
+using Microsoft.Extensions.Time.Testing;
+using NSubstitute;
+using SIGCM2.Application.Abstractions.Persistence;
+using SIGCM2.Application.Audit;
+using SIGCM2.Application.Rubros.Update;
+using SIGCM2.Domain.Entities;
+using SIGCM2.Domain.Exceptions;
+
+namespace SIGCM2.Application.Tests.Rubros.Update;
+
+public class UpdateRubroCommandHandlerTests
+{
+    private readonly IRubroRepository _repo = Substitute.For<IRubroRepository>();
+    private readonly IAuditLogger _audit = Substitute.For<IAuditLogger>();
+    private readonly FakeTimeProvider _timeProvider = new(new DateTimeOffset(2026, 4, 18, 12, 0, 0, TimeSpan.Zero));
+    private readonly UpdateRubroCommandHandler _handler;
+
+    private static Rubro ExistingRubro(int id = 3) => new(id, null, "Autos", 0, activo: true,
+        tarifarioBaseId: null, fechaCreacion: DateTime.UtcNow, fechaModificacion: null);
+
+    public UpdateRubroCommandHandlerTests()
+    {
+        _repo.ExistsByNombreUnderParentAsync(Arg.Any<int?>(), Arg.Any<string>(), Arg.Any<int?>(), Arg.Any<CancellationToken>())
+             .Returns(false);
+
+        _handler = new UpdateRubroCommandHandler(_repo, _audit, _timeProvider);
+    }
+
+    // ── Happy path: rename ───────────────────────────────────────────────────
+
+    [Fact]
+    public async Task Handle_HappyPath_Rename_ReturnsUpdatedDto()
+    {
+        _repo.GetByIdAsync(3, Arg.Any<CancellationToken>()).Returns(ExistingRubro());
+
+        var result = await _handler.Handle(new UpdateRubroCommand(Id: 3, Nombre: "Vehiculos"));
+
+        result.Nombre.Should().Be("Vehiculos");
+        result.Id.Should().Be(3);
+    }
+
+    [Fact]
+    public async Task Handle_HappyPath_Rename_CallsUpdateAsync()
+    {
+        _repo.GetByIdAsync(3, Arg.Any<CancellationToken>()).Returns(ExistingRubro());
+
+        await _handler.Handle(new UpdateRubroCommand(Id: 3, Nombre: "Vehiculos"));
+
+        await _repo.Received(1).UpdateAsync(
+            Arg.Is<Rubro>(r => r.Nombre == "Vehiculos"),
+            Arg.Any<CancellationToken>());
+    }
+
+    [Fact]
+    public async Task Handle_HappyPath_Rename_CallsAuditLog()
+    {
+        _repo.GetByIdAsync(3, Arg.Any<CancellationToken>()).Returns(ExistingRubro());
+
+        await _handler.Handle(new UpdateRubroCommand(Id: 3, Nombre: "Vehiculos"));
+
+        await _audit.Received(1).LogAsync(
+            action: "rubro.updated",
+            targetType: "Rubro",
+            targetId: "3",
+            metadata: Arg.Any<object?>(),
+            ct: Arg.Any<CancellationToken>());
+    }
+
+    // ── Not found → RubroNotFoundException ──────────────────────────────────
+
+    [Fact]
+    public async Task Handle_NotFound_ThrowsRubroNotFoundException()
+    {
+        _repo.GetByIdAsync(99, Arg.Any<CancellationToken>()).Returns((Rubro?)null);
+
+        var act = () => _handler.Handle(new UpdateRubroCommand(Id: 99, Nombre: "Cualquiera"));
+
+        await act.Should().ThrowAsync<RubroNotFoundException>()
+            .Where(ex => ex.Id == 99);
+    }
+
+    // ── Duplicate name CI under same parent → RubroNombreDuplicadoEnPadreException
+
+    [Fact]
+    public async Task Handle_DuplicateNameUnderParent_ThrowsRubroNombreDuplicadoEnPadreException()
+    {
+        _repo.GetByIdAsync(3, Arg.Any<CancellationToken>()).Returns(ExistingRubro());
+        _repo.ExistsByNombreUnderParentAsync(null, "Motos", 3, Arg.Any<CancellationToken>())
+             .Returns(true);
+
+        var act = () => _handler.Handle(new UpdateRubroCommand(Id: 3, Nombre: "Motos"));
+
+        await act.Should().ThrowAsync<RubroNombreDuplicadoEnPadreException>();
+    }
+
+    [Fact]
+    public async Task Handle_DuplicateName_DoesNotCallAuditLog()
+    {
+        _repo.GetByIdAsync(3, Arg.Any<CancellationToken>()).Returns(ExistingRubro());
+        _repo.ExistsByNombreUnderParentAsync(Arg.Any<int?>(), Arg.Any<string>(), Arg.Any<int?>(), Arg.Any<CancellationToken>())
+             .Returns(true);
+
+        try { await _handler.Handle(new UpdateRubroCommand(Id: 3, Nombre: "Motos")); } catch { }
+
+        await _audit.DidNotReceive().LogAsync(
+            Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>(),
+            Arg.Any<object?>(), Arg.Any<CancellationToken>());
+    }
+}