feat(application): repository abstraction + DTOs + validators + handlers CRUD PuntosDeVenta con auditoría + retry deadlock

2026-04-17 12:28:11 -03:00
parent 43877bd4a1
commit 50f6f2b67a
36 changed files with 1296 additions and 0 deletions
--- a/tests/SIGCM2.Application.Tests/PuntosDeVenta/Create/CreatePuntoDeVentaCommandHandlerTests.cs
+++ b/tests/SIGCM2.Application.Tests/PuntosDeVenta/Create/CreatePuntoDeVentaCommandHandlerTests.cs
@@ -0,0 +1,122 @@
+using NSubstitute;
+using SIGCM2.Application.Abstractions.Persistence;
+using SIGCM2.Application.Audit;
+using SIGCM2.Application.PuntosDeVenta.Create;
+using SIGCM2.Domain.Entities;
+using SIGCM2.Domain.Exceptions;
+
+namespace SIGCM2.Application.Tests.PuntosDeVenta.Create;
+
+public class CreatePuntoDeVentaCommandHandlerTests
+{
+    private readonly IPuntoDeVentaRepository _repo = Substitute.For<IPuntoDeVentaRepository>();
+    private readonly IMedioRepository _medioRepo = Substitute.For<IMedioRepository>();
+    private readonly IAuditLogger _audit = Substitute.For<IAuditLogger>();
+    private readonly CreatePuntoDeVentaCommandHandler _handler;
+
+    private static Medio MakeMedio(int id = 5, bool activo = true)
+        => new(id, "COD" + id, "Medio " + id, TipoMedio.Diario, null, activo, DateTime.UtcNow, null);
+
+    private static CreatePuntoDeVentaCommand ValidCommand() => new(
+        MedioId: 5,
+        NumeroAFIP: 1,
+        Nombre: "PdV Central",
+        Descripcion: null);
+
+    public CreatePuntoDeVentaCommandHandlerTests()
+    {
+        _handler = new CreatePuntoDeVentaCommandHandler(_repo, _medioRepo, _audit);
+        _medioRepo.GetByIdAsync(5, Arg.Any<CancellationToken>()).Returns(MakeMedio(5));
+        _repo.ExistsByNumeroAFIPInMedioAsync(Arg.Any<int>(), Arg.Any<short>(), Arg.Any<int?>(), Arg.Any<CancellationToken>()).Returns(false);
+        _repo.AddAsync(Arg.Any<PuntoDeVenta>(), Arg.Any<CancellationToken>()).Returns(10);
+    }
+
+    // ── medio not found → throws ─────────────────────────────────────────────
+
+    [Fact]
+    public async Task Handle_MedioNotFound_ThrowsMedioNotFoundException()
+    {
+        _medioRepo.GetByIdAsync(5, Arg.Any<CancellationToken>()).Returns((Medio?)null);
+
+        await Assert.ThrowsAsync<MedioNotFoundException>(
+            () => _handler.Handle(ValidCommand()));
+    }
+
+    // ── medio inactivo → throws ──────────────────────────────────────────────
+
+    [Fact]
+    public async Task Handle_MedioInactivo_ThrowsMedioInactivoException()
+    {
+        _medioRepo.GetByIdAsync(5, Arg.Any<CancellationToken>()).Returns(MakeMedio(5, false));
+
+        await Assert.ThrowsAsync<MedioInactivoException>(
+            () => _handler.Handle(ValidCommand()));
+    }
+
+    // ── NumeroAFIP duplicado → throws ────────────────────────────────────────
+
+    [Fact]
+    public async Task Handle_NumeroAFIPDuplicado_ThrowsNumeroAFIPDuplicadoException()
+    {
+        _repo.ExistsByNumeroAFIPInMedioAsync(5, 1, null, Arg.Any<CancellationToken>()).Returns(true);
+
+        await Assert.ThrowsAsync<NumeroAFIPDuplicadoException>(
+            () => _handler.Handle(ValidCommand()));
+    }
+
+    [Fact]
+    public async Task Handle_NumeroAFIPDuplicado_DoesNotCallAddAsync()
+    {
+        _repo.ExistsByNumeroAFIPInMedioAsync(Arg.Any<int>(), Arg.Any<short>(), Arg.Any<int?>(), Arg.Any<CancellationToken>()).Returns(true);
+
+        try { await _handler.Handle(ValidCommand()); } catch (NumeroAFIPDuplicadoException) { }
+
+        await _repo.DidNotReceive().AddAsync(Arg.Any<PuntoDeVenta>(), Arg.Any<CancellationToken>());
+    }
+
+    // ── happy path ───────────────────────────────────────────────────────────
+
+    [Fact]
+    public async Task Handle_HappyPath_ReturnsDtoWithIdFromRepository()
+    {
+        var result = await _handler.Handle(ValidCommand());
+
+        Assert.Equal(10, result.Id);
+    }
+
+    [Fact]
+    public async Task Handle_HappyPath_DtoContainsCorrectFields()
+    {
+        var result = await _handler.Handle(ValidCommand());
+
+        Assert.Equal(5, result.MedioId);
+        Assert.Equal(1, result.NumeroAFIP);
+        Assert.Equal("PdV Central", result.Nombre);
+        Assert.True(result.Activo);
+    }
+
+    [Fact]
+    public async Task Handle_HappyPath_CallsAuditWithCreateAction()
+    {
+        await _handler.Handle(ValidCommand());
+
+        await _audit.Received(1).LogAsync(
+            action: "punto_de_venta.create",
+            targetType: "PuntoDeVenta",
+            targetId: "10",
+            metadata: Arg.Any<object?>(),
+            ct: Arg.Any<CancellationToken>());
+    }
+
+    // ── audit fail-closed ────────────────────────────────────────────────────
+
+    [Fact]
+    public async Task Handle_AuditLoggerThrows_ExceptionBubblesUpAndAddNotCommitted()
+    {
+        _audit.LogAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>(), Arg.Any<object?>(), Arg.Any<CancellationToken>())
+              .Returns(Task.FromException(new InvalidOperationException("audit fail")));
+
+        await Assert.ThrowsAsync<InvalidOperationException>(
+            () => _handler.Handle(ValidCommand()));
+    }
+}